Some refactoring on how provider metadata is handled #102
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary and Scope
Performed some refactoring with how ProviderMetadata is handled.
csm.Metadata
DecodeProviderMetadata
andEncodeProviderMetadata
tocsm
package.GetProviderMetadata
andGetProviderMetadataT
were removed.csm.DecodeProviderMetadata
.-inventory.Hardware
changesinventory.Hardware
structure, as they are duplicated with the provider metadata.SetProviderMetadata
method toinventory.Hardware
map[Provider]ProviderMetadataRaw
to force the type usage for this field.pointers
package to help with dealing with pointer values.Heavily relying on the automated testing provided by
make test
to verify things are ok after the refractor.Here is what a cabinet looks like in the canidb. Notice how Provider metadata is under a different key, and that the Cabinet properties are namespaced under CSM:
Risks and Mitigations